Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new Nightmare Insert on LV-624 #5652

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

BadAtThisGame302
Copy link
Contributor

@BadAtThisGame302 BadAtThisGame302 commented Feb 3, 2024

About the pull request

Adds a new Nightmare Insert on LV, including a Paranoid Executive and his Corporate Security Detail fortifying the Corporate Dome in hopes of Company rescue. (Those corpses poor colonists in the Garage totally did not get firing lined because they tried to break in the Dome while the xenos were eating their ass.)

Explain why it's good for the game

Firstly, the Roadmap has an objective to add more nightmare inserts (Plus, I learned from my previous RMC nightmare insert and DIDN'T make them military survivors.) Secondly, this also fulfills the other roadmap objective to spawn the survivors together (Yipee!)

Now, from a balance perspective, I used the normal goon survs, added some extra metal/plasteel/sandbags, a PMC nade, a hacked PMC Motion detection and alot of barricades spread around the Dome, also moved the vendors and tables to a more defensable position and gave the CL an FP with ammo. Thought about giving them a Wey-Med or some claymores, I'll see about it.

Testing Photographs and Procedure

Screenshots & Videos

The New Corporate Dome

image

Changelog

🆑
add: Added a CL and Goon nightmare insert spawn.
mapadd: added a new nightmare insert on LV which revamps the Corporate Dome into a holdout.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge labels Feb 3, 2024
@Nanu308 Nanu308 marked this pull request as draft February 6, 2024 22:56
@BadAtThisGame302 BadAtThisGame302 marked this pull request as ready for review February 7, 2024 17:11
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 16, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Feb 19, 2024
@Drulikar
Copy link
Contributor

Removing stale to give Nanu a little more time to re-review changes.

@Nanu308 Nanu308 marked this pull request as draft February 20, 2024 02:05
@BadAtThisGame302
Copy link
Contributor Author

Mapping looking good, just drop the /2 pmc rifle.

I don't understand what you mean? There is no PMC Rifle anywhere unless I am mistaken somehow?

@BadAtThisGame302 BadAtThisGame302 marked this pull request as ready for review February 20, 2024 22:07
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Feb 22, 2024
new_human.equip_to_slot_or_del(new /obj/item/reagent_container/glass/beaker/vial/random/good(new_human), WEAR_IN_BACK)
new_human.equip_to_slot_or_del(new /obj/item/stack/sheet/metal/med_small_stack(new_human), WEAR_IN_BACK)
add_random_cl_survivor_loot(new_human)
add_random_cl_survivor_loot(new_human)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to call this twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to call this twice?

Yes, replaced the pistol (which I forgot I already gave him one) to yet another research loot spawner, didn't want a static so I put two there.

Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Birdtalon Birdtalon added this pull request to the merge queue Feb 23, 2024
Merged via the queue into cmss13-devs:master with commit 6901693 Feb 23, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 23, 2024
@BadAtThisGame302 BadAtThisGame302 deleted the nightmare branch February 23, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants